Skip to content

Format codebase + move external files to 3rdparty + add PCH#308

Merged
JanuszBedkowski merged 1 commit intoMapsHD:mainfrom
mwlasiuk:mw/code-reformat
Jan 16, 2026
Merged

Format codebase + move external files to 3rdparty + add PCH#308
JanuszBedkowski merged 1 commit intoMapsHD:mainfrom
mwlasiuk:mw/code-reformat

Conversation

@mwlasiuk
Copy link
Copy Markdown
Collaborator

@mwlasiuk mwlasiuk commented Jan 15, 2026 •
edited
Loading

  • formatted code using recently added clang-format
  • moved external files that have their GH page to 3rdparty using submodules
  • moved external files that do not have their GH page to external directory in repo root
  • simplified core and core_hd_mapping cmake files
  • added PCH to core and core_hd_mapping to simplify includes

@mwlasiuk mwlasiuk marked this pull request as draft January 15, 2026 18:57
@JanuszBedkowski
Copy link
Copy Markdown
Member

JanuszBedkowski commented Jan 15, 2026

Michal can You check why some check are failing?

@mwlasiuk mwlasiuk marked this pull request as ready for review January 15, 2026 21:09
@bloom256
Copy link
Copy Markdown
Collaborator

bloom256 commented Jan 16, 2026

I think it could be useful to add this commit to .git-blame-ignore-revs, so that git blame remains helpful after the reformat.

It might also be worth considering adding a new status check that runs something like 'clang-format -n -Werror' to help keep formatting consistent going forward.

@mwlasiuk
Copy link
Copy Markdown
Collaborator Author

mwlasiuk commented Jan 16, 2026

I think it could be useful to add this commit to .git-blame-ignore-revs, so that git blame remains helpful after the reformat.

It might also be worth considering adding a new status check that runs something like 'clang-format -n -Werror' to help keep formatting consistent going forward.

This problem is referenced also in this issue. Enforcement of clang format in future PRs can be done in next PR as this is already quite big.

@JanuszBedkowski JanuszBedkowski merged commit b321645 into MapsHD:main Jan 16, 2026
5 checks passed
@michalpelka michalpelka mentioned this pull request Jan 20, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mwlasiuk @JanuszBedkowski @bloom256